Changeset 7815

Timestamp:

02/06/2014 08:44:06 PM (13 years ago)

Author:

boonebgorges

Message:

Use API function instead of direct query in BP_Activity_Activity::append_user_fullnames()

This allows for better caching.

File:

• trunk/bp-activity/bp-activity-classes.php (modified) (1 diff)

trunk/bp-activity/bp-activity-classes.php

@@ -534 +534 @@
                 if ( bp_is_active( 'xprofile' ) && ! empty( $activities ) ) {
                         $activity_user_ids = wp_list_pluck( $activities, 'user_id' );
-                        $activity_user_ids = implode( ',', wp_parse_id_list( $activity_user_ids ) );
 
                         if ( ! empty( $activity_user_ids ) ) {
-                                $bp = buddypress();
-
-                                if ( $names = $wpdb->get_results( "SELECT user_id, value AS user_fullname FROM {$bp->profile->table_name_data} WHERE field_id = 1 AND user_id IN ({$activity_user_ids})" ) ) {
+                                $names = BP_XProfile_ProfileData::get_value_byid( 1, $activity_user_ids );
+                                if ( ! empty( $names ) ) {
 
                                         $tmp_names = array();
 
                                         foreach ( (array) $names as $name ) {
-                                                $tmp_names[ $name->user_id ] = $name->user_fullname;
+                                                $tmp_names[ $name->user_id ] = $name->value;
                                         }