Changeset 7812 for trunk/bp-core/bp-core-classes.php

Timestamp:

02/06/2014 07:38:35 PM (11 years ago)

Author:

boonebgorges

Message:

Introduce bp_xprofile_fullname_field_id() and use in query building throughout BP

There are many places throughout BuddyPress where it's necessary to query for
user fullnames. When XProfile is active, part of this process involves
determining the ID of the fullname field. Historically, this has been done by
querying for the ID of a field corresponding to the 'name' bp_xprofile_fullname_field_name().
Creating a standalone function for this allows us to centralize persistent
caching for the field ID.

As a side note, the fact that we do this query at all is a little farcical.
The fullname field is essentially necessarily tied to field #1 (due to some
hardcoding in the xprofile schema definition as well as bp-xprofile-admin.php).
We rely on the Name setting only for historical reasons, which probably didn't
even make all that much sense at the time. At some point, a serious review
should be done, and references to the fullname field id standardized (either
all hardcoded, or all not hardcoded).

See #5362

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -302 +302 @@
                 // the xprofile table
                 } else {
-                    $fullname_field_id = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$bp->profile->table_name_fields} WHERE name = %s", bp_xprofile_fullname_field_name() ) );
-
                     $this->uid_name = 'user_id';
                     $sql['select']  = "SELECT u.{$this->uid_name} as id FROM {$bp->profile->table_name_data} u";
-                    $sql['where'][] = "u.field_id = {$fullname_field_id}";
+                    $sql['where'][] = $wpdb->prepare( "u.field_id = %d", bp_xprofile_fullname_field_id() );
                     $sql['orderby'] = "ORDER BY u.value";
                     $sql['order']   = "ASC";