Changeset 7805

Timestamp:

02/05/2014 10:53:30 PM (11 years ago)

Author:

boonebgorges

Message:

Consult cache before querying in BP_XProfile_ProfileData::get_fielddataid_byid()

See #1332

Location:

trunk

Files:

• bp-xprofile/bp-xprofile-classes.php (modified) (2 diffs)
• tests/testcases/xprofile/class-bp-xprofile-profiledata.php (modified) (1 diff)

trunk/bp-xprofile/bp-xprofile-classes.php

@@ -1309 +1309 @@
 
     /**
-     * Get the user's field data id by the id of the xprofile field
+     * Get the user's field data id by the id of the xprofile field.
      *
      * @param int $field_id
@@ -1321 +1321 @@
             $fielddata_id = 0;
         } else {
-            $fielddata_id = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$bp->profile->table_name_data} WHERE field_id = %d AND user_id = %d", $field_id, $user_id ) );
+
+            // Check cache first
+            $fielddata = wp_cache_get( $field_id, 'bp_xprofile_data_' . $user_id );
+            if ( false === $fielddata || empty( $fielddata->id ) ) {
+                $fielddata_id = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM {$bp->profile->table_name_data} WHERE field_id = %d AND user_id = %d", $field_id, $user_id ) );
+            } else {
+                $fielddata_id = $fielddata->id;
+            }
         }
 

trunk/tests/testcases/xprofile/class-bp-xprofile-profiledata.php

@@ -59 +59 @@
         $this->assertTrue( $d->exists() );
     }
+
+    /**
+     * @group get_fielddataid_byid
+     */
+    public function test_get_fielddataid_byid_when_doesnt_exist() {
+        $u = $this->create_user();
+        $g = $this->factory->xprofile_group->create();
+        $f = $this->factory->xprofile_field->create( array(
+            'type' => 'textbox',
+            'field_group_id' => $g->id,
+        ) );
+
+        // Just to be sure
+        wp_cache_delete( $f->id, 'bp_xprofile_data_' . $u );
+
+        $this->assertEquals( 0, BP_XProfile_ProfileData::get_fielddataid_byid( $f->id, $u ) );
+    }
+
+    /**
+     * @group get_fielddataid_byid
+     */
+    public function test_get_fielddataid_byid_when_exists_uncached() {
+        $u = $this->create_user();
+        $g = $this->factory->xprofile_group->create();
+        $f = $this->factory->xprofile_field->create( array(
+            'type' => 'textbox',
+            'field_group_id' => $g->id,
+        ) );
+
+        $d = new BP_XProfile_ProfileData();
+        $d->user_id = $u;
+        $d->field_id = $f->id;
+        $d->value = 'foo';
+        $d->save();
+
+        // Ensure it's deleted from cache
+        wp_cache_delete( $f->id, 'bp_xprofile_data_' . $u );
+
+        $this->assertEquals( $d->id, BP_XProfile_ProfileData::get_fielddataid_byid( $f->id, $u ) );
+    }
+
+    /**
+     * @group get_fielddataid_byid
+     */
+    public function test_get_fielddataid_byid_when_exists_in_cache() {
+        $u = $this->create_user();
+        $g = $this->factory->xprofile_group->create();
+        $f = $this->factory->xprofile_field->create( array(
+            'type' => 'textbox',
+            'field_group_id' => $g->id,
+        ) );
+
+        // Fake the cache
+        $d = new stdClass;
+        $d->id = 5;
+        wp_cache_set( $f->id, $d, 'bp_xprofile_data_' . $u );
+
+        $this->assertSame( 5, BP_XProfile_ProfileData::get_fielddataid_byid( $f->id, $u ) );
+    }
 }