Changeset 7800

Timestamp:

02/05/2014 07:58:56 PM (11 years ago)

Author:

boonebgorges

Message:

Don't use func_get_args() as a function paramater

This should appease certain PHP 5.2 setups, including travis-ci

See #4294

Location:

trunk

Files:

• bp-activity/bp-activity-classes.php (modified) (1 diff)
• bp-core/bp-core-classes.php (modified) (1 diff)
• bp-core/bp-core-functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-classes.php

@@ -919 +919 @@
 
             // Legacy query - not recommended
-            if ( apply_filters( 'bp_use_legacy_activity_query', false, __METHOD__, func_get_args() ) ) {
+            $func_args = func_get_args();
+            if ( apply_filters( 'bp_use_legacy_activity_query', false, __METHOD__, $func_args ) ) {
                 $sql = apply_filters( 'bp_activity_comments_user_join_filter', $wpdb->prepare( "SELECT a.*, u.user_email, u.user_nicename, u.user_login, u.display_name{$fullname_select} FROM {$bp->activity->table_name} a, {$wpdb->users} u{$fullname_from} WHERE u.ID = a.user_id {$fullname_where} AND a.type = 'activity_comment' {$spam_sql} AND a.item_id = %d AND a.mptt_left > %d AND a.mptt_left < %d ORDER BY a.date_recorded ASC", $top_level_parent_id, $left, $right ), $activity_id, $left, $right, $spam_sql );
 

trunk/bp-core/bp-core-classes.php

@@ -1994 +1994 @@
      */
     public function walk( $elements, $max_depth ) {
-        $args   = array_slice( func_get_args(), 2 );
+        $func_args = func_get_args();
+
+        $args   = array_slice( $func_args, 2 );
         $output = '';
 

trunk/bp-core/bp-core-functions.php

@@ -113 +113 @@
     usort( $items, create_function( '$a, $b', '
         $values = array( 0 => false, 1 => false, );
-        foreach ( func_get_args() as $indexi => $index ) {
+        $func_args = func_get_args();
+        foreach ( $func_args as $indexi => $index ) {
             if ( isset( $index->' . $key . ' ) ) {
                 $values[ $indexi ] = $index->' . $key . ';