Changeset 7786

Timestamp:

02/05/2014 02:15:53 PM (11 years ago)

Author:

boonebgorges

Message:

Add persistent caching support for xprofile field data

See #1332

Location:

trunk

Files:

• bp-core/bp-core-cache.php (modified) (1 diff)
• bp-xprofile/bp-xprofile-cache.php (modified) (1 diff)
• bp-xprofile/bp-xprofile-classes.php (modified) (3 diffs)

trunk/bp-core/bp-core-cache.php

@@ -56 +56 @@
 add_action( 'bp_first_activity_for_member',   'bp_core_clear_member_count_caches' );
 add_action( 'deleted_user',                   'bp_core_clear_member_count_caches' );
+
+/**
+ * Determine which items from a list do not have cached values.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param array $item_ids ID list.
+ * @param string $cache_group The cache group to check against.
+ * @return array
+ */
+function bp_get_non_cached_ids( $item_ids, $cache_group ) {
+    $uncached = array();
+
+    foreach ( $item_ids as $item_id ) {
+        $item_id = (int) $item_id;
+        if ( false === wp_cache_get( $item_id, $cache_group ) ) {
+            $uncached[] = $item_id;
+        }
+    }
+
+    return $uncached;
+}
 
 /**

trunk/bp-xprofile/bp-xprofile-cache.php

@@ -40 +40 @@
 add_action( 'xprofile_fields_deleted_field', 'xprofile_clear_profile_field_object_cache' );
 
+/**
+ * Clear caches when a user's updates a field data object.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param BP_XProfile_ProfileData
+ */
+function xprofile_clear_profiledata_object_cache( $data_obj ) {
+    wp_cache_delete( $data_obj->field_id, 'bp_xprofile_data_' . $data_obj->user_id );
+}
+add_action( 'xprofile_data_after_save', 'xprofile_clear_profiledata_object_cache' );
+add_action( 'xprofile_data_after_delete', 'xprofile_clear_profiledata_object_cache' );
+
 // List actions to clear super cached pages on, if super cache is installed
 add_action( 'xprofile_updated_profile', 'bp_core_clear_cache' );

trunk/bp-xprofile/bp-xprofile-classes.php

@@ -194 +194 @@
 
             if ( ! empty( $field_ids ) && ! empty( $user_id ) ) {
-                $field_data = $wpdb->get_results( $wpdb->prepare( "SELECT id, field_id, value FROM {$bp->profile->table_name_data} WHERE field_id IN ( {$field_ids_sql} ) AND user_id = %d", $user_id ) );
+                $field_data = BP_XProfile_ProfileData::get_data_for_user( $user_id, $field_ids );
             }
 
@@ -1095 +1095 @@
         global $wpdb, $bp;
 
-        $sql = $wpdb->prepare( "SELECT * FROM {$bp->profile->table_name_data} WHERE field_id = %d AND user_id = %d", $field_id, $user_id );
-
-        if ( $profiledata = $wpdb->get_row( $sql ) ) {
-            $this->id           = $profiledata->id;
-            $this->user_id      = $profiledata->user_id;
-            $this->field_id     = $profiledata->field_id;
-            $this->value        = stripslashes( $profiledata->value );
-            $this->last_updated = $profiledata->last_updated;
-        } else {
-            // When no row is found, we'll need to set these properties manually
-            $this->field_id     = $field_id;
-            $this->user_id      = $user_id;
+        $cache_group = 'bp_xprofile_data_' . $user_id;
+        $profiledata = wp_cache_get( $field_id, $cache_group );
+
+        if ( false === $profiledata ) {
+            $sql = $wpdb->prepare( "SELECT * FROM {$bp->profile->table_name_data} WHERE field_id = %d AND user_id = %d", $field_id, $user_id );
+
+            if ( $profiledata = $wpdb->get_row( $sql ) ) {
+                $this->id           = $profiledata->id;
+                $this->user_id      = $profiledata->user_id;
+                $this->field_id     = $profiledata->field_id;
+                $this->value        = stripslashes( $profiledata->value );
+                $this->last_updated = $profiledata->last_updated;
+
+                wp_cache_set( $field_id, $profiledata, $cache_group );
+            } else {
+                // When no row is found, we'll need to set these properties manually
+                $this->field_id     = $field_id;
+                $this->user_id      = $user_id;
+            }
         }
     }
@@ -1196 +1203 @@
 
     /** Static Methods ********************************************************/
+
+    /**
+     * Get a user's profile data for a set of fields.
+     *
+     * @param int $user_id
+     * @param array $field_ids
+     * @return array
+     */
+    public static function get_data_for_user( $user_id, $field_ids ) {
+        global $wpdb;
+
+        $data = array();
+
+        $cache_group = 'bp_xprofile_data_' . $user_id;
+
+        $uncached_field_ids = bp_get_non_cached_ids( $field_ids, $cache_group );
+
+        // Prime the cache
+        if ( ! empty( $uncached_field_ids ) ) {
+            $bp = buddypress();
+            $uncached_field_ids_sql = implode( ',', wp_parse_id_list( $uncached_field_ids ) );
+            $uncached_data = $wpdb->get_results( $wpdb->prepare( "SELECT id, user_id, field_id, value, last_updated FROM {$bp->profile->table_name_data} WHERE field_id IN ({$uncached_field_ids_sql}) AND user_id = %d", $user_id ) );
+
+            // Rekey
+            $queried_data = array();
+            foreach ( $uncached_data as $ud ) {
+                $d               = new stdClass;
+                $d->id           = $ud->id;
+                $d->user_id      = $ud->user_id;
+                $d->field_id     = $ud->field_id;
+                $d->value        = $ud->value;
+                $d->last_updated = $ud->last_updated;
+
+                $queried_data[ $ud->field_id ] = $d;
+            }
+
+            // Set caches
+            foreach ( $field_ids as $field_id ) {
+
+                // If a value was found, cache it
+                if ( isset( $queried_data[ $field_id ] ) ) {
+                    wp_cache_set( $field_id, $queried_data[ $field_id ], $cache_group );
+
+                // If no value was found, cache an empty item
+                // to avoid future cache misses
+                } else {
+                    $d           = new stdClass;
+                    $d->id       = '';
+                    $d->field_id = $field_id;
+                    $d->value    = '';
+
+                    wp_cache_set( $field_id, $d, $cache_group );
+                }
+            }
+        }
+
+        // Now that all items are cached, fetch them
+        foreach ( $field_ids as $field_id ) {
+            $data[] = wp_cache_get( $field_id, $cache_group );
+        }
+
+        return $data;
+    }
 
     /**