Changeset 7781

Timestamp:

02/04/2014 02:19:11 AM (11 years ago)

Author:

boonebgorges

Message:

Add caching support for default xprofile field visibility settings

These settings rarely change, and so are good candidates for persistent caching

See #1332

Location:

trunk/bp-xprofile

Files:

• bp-xprofile-cache.php (modified) (1 diff)
• bp-xprofile-classes.php (modified) (1 diff)

trunk/bp-xprofile/bp-xprofile-cache.php

@@ -18 +18 @@
     wp_cache_delete( 'xprofile_group_' . $group_obj->id, 'bp' );
 }
+add_action( 'xprofile_groups_deleted_group', 'xprofile_clear_profile_groups_object_cache' );
+add_action( 'xprofile_groups_saved_group',   'xprofile_clear_profile_groups_object_cache' );
 
 function xprofile_clear_profile_data_object_cache( $group_id ) {
     wp_cache_delete( 'bp_user_fullname_' . bp_loggedin_user_id(), 'bp' );
 }
+add_action( 'xprofile_updated_profile', 'xprofile_clear_profile_data_object_cache'   );
 
-// List actions to clear object caches on
-add_action( 'xprofile_groups_deleted_group', 'xprofile_clear_profile_groups_object_cache' );
-add_action( 'xprofile_groups_saved_group',   'xprofile_clear_profile_groups_object_cache' );
-add_action( 'xprofile_updated_profile',      'xprofile_clear_profile_data_object_cache'   );
+/**
+ * Clear caches when a field object is modified.
+ *
+ * @since BuddyPress (2.0.0)
+ *
+ * @param BP_XProfile_Field
+ */
+function xprofile_clear_profile_field_object_cache( $field_obj ) {
+    // Clear default visibility level cache
+    wp_cache_delete( 'xprofile_default_visibility_levels', 'bp' );
+}
+add_action( 'xprofile_fields_saved_field', 'xprofile_clear_profile_field_object_cache' );
+add_aciton( 'xprofile_fields_deleted_field', 'xprofile_clear_profile_field_object_cache' );
 
 // List actions to clear super cached pages on, if super cache is installed

trunk/bp-xprofile/bp-xprofile-classes.php

@@ -389 +389 @@
 
     /**
-     * Fetch the admin-set preferences for all fields
-     *
-     * @since BuddyPress (1.6)
-     *
-     * @return array $default_visibility_levels An array, keyed by field_id, of default
-     *   visibility level + allow_custom (whether the admin allows this field to be set by user)
+     * Fetch the admin-set preferences for all fields.
+     *
+     * @since BuddyPress (1.6.0)
+     *
+     * @return array $default_visibility_levels An array, keyed by
+     *         field_id, of default visibility level + allow_custom
+     *         (whether the admin allows this field to be set by user)
      */
     public static function fetch_default_visibility_levels() {
         global $wpdb, $bp;
 
-        $levels = $wpdb->get_results( "SELECT object_id, meta_key, meta_value FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND ( meta_key = 'default_visibility' OR meta_key = 'allow_custom_visibility' )" );
-
-        // Arrange so that the field id is the key and the visibility level the value
-        $default_visibility_levels = array();
-        foreach( $levels as $level ) {
-            if ( 'default_visibility' == $level->meta_key ) {
-                $default_visibility_levels[$level->object_id]['default'] = $level->meta_value;
-            } else if ( 'allow_custom_visibility' == $level->meta_key ) {
-                $default_visibility_levels[$level->object_id]['allow_custom'] = $level->meta_value;
-            }
+        $default_visibility_levels = wp_cache_get( 'xprofile_default_visibility_levels', 'bp' );
+
+        if ( false === $default_visibility_levels ) {
+            $levels = $wpdb->get_results( "SELECT object_id, meta_key, meta_value FROM {$bp->profile->table_name_meta} WHERE object_type = 'field' AND ( meta_key = 'default_visibility' OR meta_key = 'allow_custom_visibility' )" );
+
+            // Arrange so that the field id is the key and the visibility level the value
+            $default_visibility_levels = array();
+            foreach ( $levels as $level ) {
+                if ( 'default_visibility' == $level->meta_key ) {
+                    $default_visibility_levels[ $level->object_id ]['default'] = $level->meta_value;
+                } else if ( 'allow_custom_visibility' == $level->meta_key ) {
+                    $default_visibility_levels[ $level->object_id ]['allow_custom'] = $level->meta_value;
+                }
+            }
+
+            wp_cache_set( 'xprofile_default_visibility_levels', $default_visibility_levels, 'bp' );
         }