Changeset 7773 for trunk/bp-activity/bp-activity-classes.php

Timestamp:

02/03/2014 02:43:51 AM (12 years ago)

Author:

boonebgorges

Message:

Fix persistent caching for BP_Activity_Activity::get_activity_comments()

• Use the 'bp' cache group consistently
• When a query shows that an activity item has no comments, do not cache the boolean value false. This will cause a cache miss the next time around. Instead, store the string 'none', and then convert it to false when requerying.

Fixes #5369

File:

• trunk/bp-activity/bp-activity-classes.php (modified) (2 diffs)

trunk/bp-activity/bp-activity-classes.php

@@ -868 +868 @@
                 }
 
-                if ( !$comments = wp_cache_get( 'bp_activity_comments_' . $activity_id ) ) {
+                $comments = wp_cache_get( 'bp_activity_comments_' . $activity_id, 'bp' );
+
+                // We store the string 'none' to cache the fact that the
+                // activity item has no comments
+                if ( 'none' === $comments ) {
+                        $comments = false;
+
+                // A true cache miss
+                } else if ( empty( $comments ) ) {
 
                         // Select the user's fullname with the query
@@ -912 +920 @@
                                 }
                         }
-                        wp_cache_set( 'bp_activity_comments_' . $activity_id, $comments, 'bp' );
+
+                        // If we cache a value of false, it'll count as a cache
+                        // miss the next time the activity comments are fetched.
+                        // Storing the string 'none' is a hack workaround to
+                        // avoid unnecessary queries.
+                        if ( false === $comments ) {
+                                $cache_value = 'none';
+                        } else {
+                                $cache_value = $comments;
+                        }
+
+                        wp_cache_set( 'bp_activity_comments_' . $activity_id, $cache_value, 'bp' );
                 }