Changeset 7660

Timestamp:

12/09/2013 02:34:02 PM (11 years ago)

Author:

boonebgorges

Message:

Calculate fallback value for BP_User_Query::total_users

BP_User_Query normally calculates the total_users count with a separate COUNT
query; see BP_User_Query::do_user_ids_query(). However, this method is not
called when a $user_ids parameter is passed to BP_User_Query. This changeset
introduces an alternative method for calculating total_users in this case,
ensuring that pagination works as expected.

Fixes #5271

Props imath

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -461 +461 @@
         ), $this ) );
 
+        // We calculate total_users using a standalone query, except
+        // when a whitelist of user_ids is passed to the constructor.
+        // This clause covers the latter situation, and ensures that
+        // pagination works when querying by $user_ids.
+        if ( empty( $this->total_users ) ) {
+            $this->total_users = count( $wp_user_query->results );
+        }
+
         // Reindex for easier matching
         $r = array();