Changeset 7650 for trunk/bp-messages/bp-messages-notifications.php

Timestamp:

12/06/2013 04:28:25 PM (12 years ago)

Author:

boonebgorges

Message:

Cast args to a new variable in messages_notification_new_message()

r7621 made it possible for this function to accept a $message object in
addition to an array, by casting the arguments to an array. However, this
caused downstream problems when the $message object was passed by reference,
as in the case of 'messages_message_sent'. This changeset leaves the passed
object untouched.

Fixes #5273

File:

• trunk/bp-messages/bp-messages-notifications.php (modified) (1 diff)

trunk/bp-messages/bp-messages-notifications.php

@@ -17 +17 @@
  *
  * @since BuddyPress (1.0)
- * @param array $args
+ * @param array $raw_args
  */
-function messages_notification_new_message( $args = array() ) {
+function messages_notification_new_message( $raw_args = array() ) {
 
     // Cast possible $message object as an array
-    if ( is_object( $args ) ) {
-        $args = (array) $args;
+    if ( is_object( $raw_args ) ) {
+        $args = (array) $raw_args;
+    } else {
+        $args = $raw_args;
     }