Changeset 7638 for trunk/bp-core/bp-core-classes.php

Timestamp:

12/02/2013 08:49:29 PM (12 years ago)

Author:

boonebgorges

Message:

Prevent BP_User_Query from fetching spam users on alphabetical sort

BP_User_Query's 'alphabetical' sort type, in contrast to the other values of
'type', does not look at users' last_activity usermeta value. As a result, it
cannot infer spam/deleted/activated status in the same way as the other 'type'
values. To prevent spammed/deleted/unactivated users from being returned on
alphabetical sorts, we do a subquery that limits results to user_status = 0.

Fixes #5114

Props sbrajesh, imath

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -311 +311 @@
                 }
 
+                // Alphabetical queries ignore last_activity, while BP uses last_activity
+                // to infer spam/deleted/non-activated users. To ensure that these users
+                // are filtered out, we add an appropriate sub-query.
+                $sql['where'][] = "u.{$this->uid_name} IN ( SELECT ID FROM {$wpdb->users} WHERE " . bp_core_get_status_sql( '' ) . " )";
+
                 break;