Changeset 7577

Timestamp:

11/15/2013 09:31:46 PM (11 years ago)

Author:

boonebgorges

Message:

Publish blog posts to the activity stream based on transition_post_status

BP has historically had problems when posting certain kinds of blog posts to
the activity stream, such as improper bumping for post edits and incorrect
timestamps for scheduled posts. These problems stem from the fact that
bp_blogs_record_post has been hooked to the generic 'save_post'. Using
'transition_post_status' instead allows BP to prevent edit-bumps, while
allowing bp_blogs_record_post() to use post_date_gmt for activity timestamps
(thereby properly attributing scheduled posts).

See #3746, #2546.

Fixes #4090

File:

• trunk/bp-blogs/bp-blogs-functions.php (modified) (3 diffs)

trunk/bp-blogs/bp-blogs-functions.php

@@ -248 +248 @@
 
 /**
+ * Detect a change in post status, and initiate an activity update if necessary.
+ *
+ * Posts get new activity updates when (a) they are being published, and (b)
+ * they have not already been published. This enables proper posting for
+ * regular posts as well as scheduled posts, while preventing post bumping.
+ *
+ * See #4090, #3746, #2546 for background.
+ *
+ * @since BuddyPress (1.9.0)
+ *
+ * @param string $new_status New status for the post.
+ * @param string $old_status Old status for the post.
+ * @param object $post Post data.
+ */
+function bp_blogs_catch_published_post( $new_status, $old_status, $post ) {
+
+    // Only record published posts
+    if ( 'publish' !== $new_status ) {
+        return;
+    }
+
+    // Don't record edits (publish -> publish)
+    if ( 'publish' === $old_status ) {
+        return;
+    }
+
+    return bp_blogs_record_post( $post->ID, $post );
+}
+add_action( 'transition_post_status', 'bp_blogs_catch_published_post', 10, 3 );
+
+/**
  * Record a new blog post in the BuddyPress activity stream.
  *
@@ -327 +358 @@
                 'item_id'           => $blog_id,
                 'secondary_item_id' => $post_id,
-                'recorded_time'     => $post->post_modified_gmt
+                'recorded_time'     => $post->post_date_gmt,
             ));
         }
@@ -339 +370 @@
     do_action( 'bp_blogs_new_blog_post', $post_id, $post, $user_id );
 }
-add_action( 'save_post', 'bp_blogs_record_post', 10, 2 );
 
 /**