Changeset 7576

Timestamp:

11/15/2013 09:08:20 PM (13 years ago)

Author:

boonebgorges

Message:

Allow 0 to be stored in activitymeta

Previously, any value where empty( $value ) evaluated to true would result
in the deletion of the row. This change allows for 0 to be stored as a
legitimate value.

This is a stopgap until BP's meta functions are refactored to use WP's core
*_metadata() functions.

Fixes #5083

Location:

trunk

Files:

• bp-activity/bp-activity-functions.php (modified) (1 diff)
• tests/testcases/activity/functions.php (modified) (1 diff)

trunk/bp-activity/bp-activity-functions.php

@@ -747 +747 @@
         $meta_value = maybe_serialize( $meta_value );
 
-        // If value is empty, delete the meta key
-        if ( empty( $meta_value ) )
+        // If value is false, delete the meta key
+        if ( false === $meta_value )
                 return bp_activity_delete_meta( $activity_id, $meta_key );
 

trunk/tests/testcases/activity/functions.php

@@ -103 +103 @@
 
         /**
+         * @group bp_activity_update_meta
+         * @ticket BP5083
+         */
+        public function test_bp_activity_update_meta_with_0() {
+                $a = $this->factory->activity->create();
+                $meta_value = 0;
+
+                bp_activity_update_meta( $a, '0_test', $meta_value );
+
+                $this->assertNotSame( false, bp_activity_get_meta( $a, '0_test' ) );
+        }
+
+        /**
          * @group bp_activity_get_user_mentionname
          */