Changeset 7570 for trunk/tests/testcases/activity/functions.php

Timestamp:

11/14/2013 03:43:43 PM (12 years ago)

Author:

boonebgorges

Message:

Remove BuddyPress's restriction spaces in user_login

BuddyPress has historically enforced a no-spaces rule on user_login during
user registration. Originally this was rooted in WPMU's own peculiar character
restrictions, and when the MU requirement was dropped, the same restrictions
were carried over to WordPress Single.

However, these restrictions have caused various problems. BP enforced the "no
spaces" rule during registration by simply swapping out spaces with hyphens and
not telling users. This caused immense confusion. Moreover, the restriction
caused problems when bypassing BP's native user registration, as when
integrating with an external authentication service; these external usernames
*can* sometimes have spaces, and certain areas of BuddyPress were not equipped
to deal with them.

This changeset removes the no-spaces restriction from BuddyPress, and hands
off user_login validation to WordPress Multisite when possible (meaning that on
MS, spaces will still not be allowed during native registration). It also
makes the necessary adjustments throughout BuddyPress to ensure that spaces
in user_login will not break related functionality. On a normal setup, BP (and
WP) only use user_login for authentication, but several changes were necessary
to account for "username compatibility mode", where the user_login is displayed
publicly:

• Refactor the way that activity @-mentions work in username compatibility mode. We now have functions for converting user IDs to "mentionname" (and vice versa) which will produce @-mention-safe versions of user_nicename or user_login, as appropriate.
• Use proper URL encoding when building and parsing URLs that contain usernames when compatibility mode is enabled.
• Fix private messaging autocomplete to work with spaces.

See #4622

Fixes #5185

File:

• trunk/tests/testcases/activity/functions.php (modified) (1 diff)

trunk/tests/testcases/activity/functions.php

@@ -101 +101 @@
         $this->assertEquals( $meta_value, bp_activity_get_meta( $a, 'linebreak_test' ) );
     }
+
+    /**
+     * @group bp_activity_get_user_mentionname
+     */
+    public function test_bp_activity_get_user_mentionname_compatibilitymode_off() {
+        add_filter( 'bp_is_username_compatibility_mode', '__return_false' );
+
+        $u = $this->create_user( array(
+            'user_login' => 'foo bar baz',
+            'user_nicename' => 'foo-bar-baz',
+        ) );
+
+        $this->assertEquals( 'foo-bar-baz', bp_activity_get_user_mentionname( $u ) );
+
+        remove_filter( 'bp_is_username_compatibility_mode', '__return_false' );
+    }
+
+    /**
+     * @group bp_activity_get_user_mentionname
+     */
+    public function test_bp_activity_get_user_mentionname_compatibilitymode_on() {
+        add_filter( 'bp_is_username_compatibility_mode', '__return_true' );
+
+        $u1 = $this->create_user( array(
+            'user_login' => 'foo bar baz',
+            'user_nicename' => 'foo-bar-baz',
+        ) );
+
+        $u2 = $this->create_user( array(
+            'user_login' => 'foo.bar.baz',
+            'user_nicename' => 'foo-bar-baz',
+        ) );
+
+        $this->assertEquals( 'foo-bar-baz', bp_activity_get_user_mentionname( $u1 ) );
+        $this->assertEquals( 'foo.bar.baz', bp_activity_get_user_mentionname( $u2 ) );
+
+        remove_filter( 'bp_is_username_compatibility_mode', '__return_true' );
+    }
+
+    /**
+     * @group bp_activity_get_userid_from_mentionname
+     */
+    public function test_bp_activity_get_userid_from_mentionname_compatibilitymode_off() {
+        add_filter( 'bp_is_username_compatibility_mode', '__return_false' );
+
+        $u = $this->create_user( array(
+            'user_login' => 'foo bar baz',
+            'user_nicename' => 'foo-bar-baz',
+        ) );
+
+        $this->assertEquals( $u, bp_activity_get_userid_from_mentionname( 'foo-bar-baz' ) );
+
+        remove_filter( 'bp_is_username_compatibility_mode', '__return_false' );
+    }
+
+    /**
+     * @group bp_activity_get_userid_from_mentionname
+     */
+    public function test_bp_activity_get_userid_from_mentionname_compatibilitymode_on() {
+        add_filter( 'bp_is_username_compatibility_mode', '__return_true' );
+
+        // all spaces are hyphens
+        $u1 = $this->create_user( array(
+            'user_login' => 'foo bar baz',
+            'user_nicename' => 'foobarbaz',
+        ) );
+
+        // no spaces are hyphens
+        $u2 = $this->create_user( array(
+            'user_login' => 'foo-bar-baz-1',
+            'user_nicename' => 'foobarbaz-1',
+        ) );
+
+        // some spaces are hyphens
+        $u3 = $this->create_user( array(
+            'user_login' => 'foo bar-baz 2',
+            'user_nicename' => 'foobarbaz-2',
+        ) );
+
+        $u4 = $this->create_user( array(
+            'user_login' => 'foo.bar.baz',
+            'user_nicename' => 'foo-bar-baz',
+        ) );
+
+        $this->assertEquals( $u1, bp_activity_get_userid_from_mentionname( 'foo-bar-baz' ) );
+        $this->assertEquals( $u2, bp_activity_get_userid_from_mentionname( 'foo-bar-baz-1' ) );
+        $this->assertEquals( $u3, bp_activity_get_userid_from_mentionname( 'foo-bar-baz-2' ) );
+        $this->assertEquals( $u4, bp_activity_get_userid_from_mentionname( 'foo.bar.baz' ) );
+
+        remove_filter( 'bp_is_username_compatibility_mode', '__return_true' );
+    }
+
 }