Changeset 7478

Timestamp:

10/24/2013 10:04:58 PM (12 years ago)

Author:

r-a-y

Message:

Use 'user_nicename' when adding a member via autocomplete in the group
admin dashboard page.

Previously, 'user_login' was used, which is an unsanitized version of the
username. When attempting to add a member with special characters (such
as an email address), the JS would throw an error.

Switching to 'user_nicename' allows a sanitized version of the username to
be used and fixes the issue with the autocomplete JS.

Fixes #5187.

File:

• trunk/bp-groups/bp-groups-admin.php (modified) (2 diffs)

trunk/bp-groups/bp-groups-admin.php

@@ -234 +234 @@
                 // Make sure the user exists before attempting
                 // to add to the group
-                if ( ! $user_id = username_exists( $un ) ) {
-                    $error_new[]   = $un;
-                } else if ( ! groups_join_group( $group_id, $user_id ) ) {
-                    $error_new[]   = $un;
+                $user = get_user_by( 'slug', $un );
+
+                if ( empty( $user ) ) {
+                    $error_new[] = $un;
                 } else {
-                    $success_new[] = $un;
+                    if ( ! groups_join_group( $group_id, $user->ID ) ) {
+                        $error_new[]   = $un;
+                    } else {
+                        $success_new[] = $un;
+                    }
                 }
             }
@@ -978 +982 @@
         $return[] = array(
             /* translators: 1: user_login, 2: user_email */
-            'label' => sprintf( __( '%1$s (%2$s)' ), $user->user_login, $user->user_email ),
-            'value' => $user->user_login,
+            'label' => sprintf( __( '%1$s (%2$s)' ), bp_is_username_compatibility_mode() ? $user->user_login : $user->user_nicename, $user->user_email ),
+            'value' => $user->user_nicename,
         );
     }