Changeset 7461

Timestamp:

10/23/2013 02:36:30 AM (13 years ago)

Author:

r-a-y

Message:

Do not use wp_parse_id_list() twice in static group get() methods.

BP_Groups_Group::get_group_extras() already uses the wp_parse_id_list()
function to sanitize the group IDs.

No need to sanitize before the get_group_extras() method call.

File:

• trunk/bp-groups/bp-groups-classes.php (modified) (5 diffs)

trunk/bp-groups/bp-groups-classes.php

@@ -523 +523 @@
                 // Populate some extra information instead of querying each time in the loop
                 if ( !empty( $r['populate_extras'] ) ) {
-                        $group_ids = implode( ',', wp_parse_id_list( $group_ids ) );
                         $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, $r['type'] );
                 }
@@ -706 +705 @@
 
                 if ( !empty( $populate_extras ) ) {
-                        foreach ( (array) $paged_groups as $group ) $group_ids[] = $group->id;
-                        $group_ids = implode( ',', wp_parse_id_list( $group_ids ) );
+                        foreach ( (array) $paged_groups as $group ) {
+                                $group_ids[] = $group->id;
+                        }
                         $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
                 }
@@ -747 +747 @@
 
                 if ( !empty( $populate_extras ) ) {
-                        foreach ( (array) $paged_groups as $group ) $group_ids[] = $group->id;
-                        $group_ids = implode( ',', wp_parse_id_list( $group_ids ) );
+                        foreach ( (array) $paged_groups as $group ) {
+                                $group_ids[] = $group->id;
+                        }
                         $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
                 }
@@ -790 +791 @@
                                 $group_ids[] = $group->id;
                         }
-                        $group_ids    = implode( ',', wp_parse_id_list( $group_ids ) );
                         $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
                 }
@@ -829 +829 @@
 
                 if ( !empty( $populate_extras ) ) {
-                        foreach ( (array) $paged_groups as $group ) $group_ids[] = $group->id;
-                        $group_ids = implode( ',', wp_parse_id_list( $group_ids ) );
+                        foreach ( (array) $paged_groups as $group ) {
+                                $group_ids[] = $group->id;
+                        }
                         $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
                 }