Changeset 7437

Timestamp:

10/17/2013 04:04:41 PM (13 years ago)

Author:

boonebgorges

Message:

Canonical URL detection should be sensitive to page_on_front

When a BP directory is set to page_on_front, it should no longer be accessible
at the regular directory URL (to avoid duplicate URLs for the same content).

A special exception is required for the Register page. Because BP blocks access
to Register for logged-in users, the canonical redirect for Register when
viewed by a logged-in user must be something other than the front page. As in
bp_core_screen_signup(), we use the Members directory in this case (a page we
can be reasonably sure will always be present).

Fixes #5199

File:

• trunk/bp-core/bp-core-catchuri.php (modified) (1 diff)

trunk/bp-core/bp-core-catchuri.php

@@ -622 +622 @@
     extract( $r );
 
+    // Special case: when a BuddyPress directory (eg example.com/members)
+    // is set to be the front page, ensure that the current canonical URL
+    // is the home page URL.
+    if ( 'page' == get_option( 'show_on_front' ) && $page_on_front = (int) get_option( 'page_on_front' ) ) {
+        $front_page_component = array_search( $page_on_front, bp_core_get_directory_page_ids() );
+
+        // If requesting the front page component directory, canonical
+        // URL is the front page
+        if ( false !== $front_page_component && is_page( $page_on_front ) ) {
+            $bp->canonical_stack['canonical_url'] = trailingslashit( bp_get_root_domain() );
+
+        // Except when the front page is set to the registration page
+        // and the current user is logged in. In this case we send to
+        // the members directory to avoid redirect loops
+        } else if ( bp_is_register_page() && 'register' == $front_page_component && is_user_logged_in() ) {
+            $bp->canonical_stack['canonical_url'] = apply_filters( 'bp_loggedin_register_page_redirect_to', trailingslashit( bp_get_root_domain() . '/' . bp_get_members_root_slug() ) );
+        }
+    }
+
     if ( empty( $bp->canonical_stack['canonical_url'] ) ) {
         // Build the URL in the address bar