Changeset 7436

Timestamp:

10/17/2013 02:20:41 AM (12 years ago)

Author:

boonebgorges

Message:

Don't use extract() in bp_get_message_thread_avatar()

Just don't do it, dude.

File:

• trunk/bp-messages/bp-messages-template.php (modified) (1 diff)

trunk/bp-messages/bp-messages-template.php

@@ -362 +362 @@
 
         $r = wp_parse_args( $args, $defaults );
-        extract( $r, EXTR_SKIP );
-
-        return apply_filters( 'bp_get_message_thread_avatar', bp_core_fetch_avatar( array( 'item_id' => $messages_template->thread->last_sender_id, 'type' => $type, 'alt' => $alt, 'css_id' => $id, 'class' => $class, 'width' => $width, 'height' => $height ) ) );
+
+        return apply_filters( 'bp_get_message_thread_avatar', bp_core_fetch_avatar( array(
+            'item_id' => $messages_template->thread->last_sender_id,
+            'type'    => $r['type'],
+            'alt'     => $r['alt'],
+            'css_id'  => $r['id'],
+            'class'   => $r['class'],
+            'width'   => $r['width'],
+            'height'  => $r['height'],
+        ) ) );
     }