Changeset 7422 for trunk/tests/testcases/activity/functions.php

Timestamp:

10/13/2013 02:36:04 AM (13 years ago)

Author:

r-a-y

Message:

Delete activity comment meta when deleting parent activity items.

Previously, when deleting parent activity items, BP would delete the
related activity comments, but not the activity comment metadata.

To solve this, activity comments are now queried and removed in the
main BP_Activity_Activity::delete() method and the activity comment
IDs are now properly passed to the delete_activity_meta_entries()
method.

Commit also includes a unit test for this issue.

Hat-tip boonebgorges for feedback.

Fixes #5097.

File:

• trunk/tests/testcases/activity/functions.php (modified) (1 diff)

trunk/tests/testcases/activity/functions.php

@@ -35 +35 @@
         }
 
+        /**
+         * @group delete
+         */
+        public function test_delete_activity_and_meta() {
+                // create an activity update
+                $parent_activity = $this->factory->activity->create( array(
+                        'type' => 'activity_update',
+                ) );
+
+                // create some activity comments
+                $comment_one = $this->factory->activity->create( array(
+                        'type'              => 'activity_comment',
+                        'item_id'           => $parent_activity,
+                        'secondary_item_id' => $parent_activity,
+                ) );
+
+                $comment_two = $this->factory->activity->create( array(
+                        'type'              => 'activity_comment',
+                        'item_id'           => $parent_activity,
+                        'secondary_item_id' => $parent_activity,
+                ) );
+
+                // add some meta to the activity items
+                bp_activity_update_meta( $parent_activity, 'foo', 'bar' );
+                bp_activity_update_meta( $comment_one,     'foo', 'bar' );
+                bp_activity_update_meta( $comment_two,     'foo', 'bar' );
+
+                // now delete the parent activity item
+                // this should hopefully delete the associated comments and meta entries
+                bp_activity_delete( array(
+                        'id' => $parent_activity
+                ) );
+
+                // now fetch the deleted activity entries
+                $get = bp_activity_get( array(
+                        'in'               => array( $parent_activity, $comment_one, $comment_two ),
+                        'display_comments' => 'stream'
+                ) );
+
+                // activities should equal zero
+                $this->assertEquals( 0, $get['total'] );
+
+                // now fetch activity meta for the deleted activity entries
+                $m1 = bp_activity_get_meta( $parent_activity );
+                $m2 = bp_activity_get_meta( $comment_one );
+                $m3 = bp_activity_get_meta( $comment_two );
+
+                // test if activity meta entries still exist
+                $this->assertEquals( false, $m1 );
+                $this->assertEquals( false, $m2 );
+                $this->assertEquals( false, $m3 );
+        }
 }