Changeset 7338 for trunk/tests/testcases/core/class-bp-user-query.php

Timestamp:

08/05/2013 02:42:16 PM (13 years ago)

Author:

boonebgorges

Message:

Use esc_sql() instead of $wpdb->escape() throughout

WordPress 3.6 deprecated the use of $wpdb->escape() for sanitizing SQL
query fragments, in favor of the rewritten esc_sql(). This changeset
makes the appropriate changes throughout BuddyPress.

In a few places, this changeset also removes redundant sanitization, in
particular when using wp_parse_id_list().

Also adds a unit test for a touched method (BP_User_Query, when using
the 'exclude' parameter).

Fixes #5100

Props needle

File:

• trunk/tests/testcases/core/class-bp-user-query.php (modified) (1 diff)

trunk/tests/testcases/core/class-bp-user-query.php

@@ -201 +201 @@
                 $this->assertEquals( $user_id, $found_user_id );
         }
+
+        /**
+         * @group exclude
+         */
+        public function test_bp_user_query_with_exclude() {
+                // Grab list of existing users who should also be excluded
+                global $wpdb;
+                $existing_users = $wpdb->get_col( "SELECT ID FROM {$wpdb->users}" );
+
+                $u1 = $this->create_user();
+                $u2 = $this->create_user();
+
+                $exclude = array_merge( array( $u1 ), $existing_users );
+                $q = new BP_User_Query( array( 'exclude' => $exclude, ) );
+
+                $found_user_ids = null;
+                if ( ! empty( $q->results ) ) {
+                        $found_user_ids = array_values( wp_parse_id_list( wp_list_pluck( $q->results, 'ID' ) ) );
+                }
+
+                $this->assertEquals( array( $u2 ), $found_user_ids );
+        }
 }