Changeset 7338 for trunk/bp-forums/bp-forums-functions.php

Timestamp:

08/05/2013 02:42:16 PM (13 years ago)

Author:

boonebgorges

Message:

Use esc_sql() instead of $wpdb->escape() throughout

WordPress 3.6 deprecated the use of $wpdb->escape() for sanitizing SQL
query fragments, in favor of the rewritten esc_sql(). This changeset
makes the appropriate changes throughout BuddyPress.

In a few places, this changeset also removes redundant sanitization, in
particular when using wp_parse_id_list().

Also adds a unit test for a touched method (BP_User_Query, when using
the 'exclude' parameter).

Fixes #5100

Props needle

File:

• trunk/bp-forums/bp-forums-functions.php (modified) (2 diffs)

trunk/bp-forums/bp-forums-functions.php

@@ -463 +463 @@
         // Get the topic ids
         foreach ( (array) $topics as $topic ) $topic_ids[] = $topic->topic_id;
-        $topic_ids = $wpdb->escape( join( ',', (array) $topic_ids ) );
+        $topic_ids = implode( ',', wp_parse_id_list( $topic_ids ) );
 
         // Fetch the topic's last poster details
@@ -597 +597 @@
         // Get the user ids
         foreach ( (array) $posts as $post ) $user_ids[] = $post->poster_id;
-        $user_ids = $wpdb->escape( join( ',', (array) $user_ids ) );
+        $user_ids = implode( ',', wp_parse_id_list( $user_ids ) );
 
         // Fetch the poster's user_email, user_nicename and user_login