Changeset 7338 for trunk/bp-core/bp-core-classes.php

Timestamp:

08/05/2013 02:42:16 PM (11 years ago)

Author:

boonebgorges

Message:

Use esc_sql() instead of $wpdb->escape() throughout

WordPress 3.6 deprecated the use of $wpdb->escape() for sanitizing SQL
query fragments, in favor of the rewritten esc_sql(). This changeset
makes the appropriate changes throughout BuddyPress.

In a few places, this changeset also removes redundant sanitization, in
particular when using wp_parse_id_list().

Also adds a unit test for a touched method (BP_User_Query, when using
the 'exclude' parameter).

Fixes #5100

Props needle

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -331 +331 @@
         // 'exclude' - User ids to exclude from the results
         if ( false !== $exclude ) {
-            $exclude        = wp_parse_id_list( $exclude );
-            $exclude_ids    = $wpdb->escape( implode( ',', (array) $exclude ) );
+            $exclude_ids    = implode( ',', wp_parse_id_list( $exclude ) );
             $sql['where'][] = "u.{$this->uid_name} NOT IN ({$exclude_ids})";
         }