Changeset 7294 for trunk/tests/testcases/groups/template.php

Timestamp:

07/23/2013 03:32:47 PM (13 years ago)

Author:

boonebgorges

Message:

Tell BP_Group_Member_Query queries to order by FIELD()

BP_Group_Member_Query works by first querying for a list of group members
that match the query params, sorted by date_modified. Then, it feeds those ids
to the BP_User_Query parent class. In order to maintain the proper
date_modified sort, we have to override BP_User_Query's ORDER BY param, and
replace it with ORDER BY FIELD(), using the user ids from the first query.

This fixes a regression in BP 1.8, where the default sort order for
bp_group_has_members() was inadvertantly changed to user_id DESC, rather than
the legacy date_modified that existed before the introduction of
BP_Group_Member_Query.

Fixes #5106

File:

• trunk/tests/testcases/groups/template.php (modified) (1 diff)

trunk/tests/testcases/groups/template.php

@@ -352 +352 @@
     }
 
+    /**
+     * Default sort order should be the joined date
+     *
+     * @tickett BP5106
+     * @group bp_group_has_members
+     */
+    public function test_bp_group_has_members_default_order() {
+        $u1 = $this->create_user( array(
+            'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 60 ),
+        ) );
+        $u2 = $this->create_user( array(
+            'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 600 ),
+        ) );
+        $u3 = $this->create_user( array(
+            'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 6000 ),
+        ) );
+
+
+        $g = $this->factory->group->create( array(
+            'creator_id' => $u1,
+        ) );
+
+        $this->add_user_to_group( $u2, $g, array(
+            'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*24 ),
+        ) );
+
+        $this->add_user_to_group( $u3, $g, array(
+            'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*12 ),
+        ) );
+
+        global $members_template;
+        bp_group_has_members( array(
+            'group_id' => $g,
+            'exclude_banned' => 0,
+            'exclude_admins_mods' => false,
+        ) );
+
+        $ids = wp_parse_id_list( wp_list_pluck( $members_template->members, 'user_id' ) );
+        $this->assertEquals( array( $u1, $u3, $u2, ), $ids );
+    }
 }