Changeset 7288

Timestamp:

07/22/2013 05:35:06 PM (12 years ago)

Author:

boonebgorges

Message:

Remove pass-by-reference for objects in selected places in BP

Since PHP 5.0, objects have been passed by reference by default. In more recent
versions of PHP, standards notices have been introduced to increasingly
deprecate the practice of passing objects by reference using an ampersand.

This changeset removes several of these strict standard notices, by removing
the explicit pass-by-reference for the objects in question.

See #5108

Location:

trunk

Files:

• bp-core/bp-core-catchuri.php (modified) (2 diffs)
• bp-loader.php (modified) (1 diff)

trunk/bp-core/bp-core-catchuri.php

@@ -365 +365 @@
     // Make the queried/post object an actual valid page
     if ( !empty( $object_id ) ) {
-        $wp_query->queried_object    = &get_post( $object_id );
+        $wp_query->queried_object    = get_post( $object_id );
         $wp_query->queried_object_id = $object_id;
         $post                        = $wp_query->queried_object;
@@ -655 +655 @@
 
     if ( !$include_query_args ) {
-        $canonical_url = array_pop( array_reverse( explode( '?', $canonical_url ) ) );
+        $canonical_url = array_reverse( explode( '?', $canonical_url ) );
+        $canonical_url = array_pop( $canonical_url );
     }
 

trunk/bp-loader.php

@@ -600 +600 @@
 // "And now here's something we hope you'll really like!"
 } else {
-    $GLOBALS['bp'] = &buddypress();
+    $GLOBALS['bp'] = buddypress();
 }