Changeset 7182 for trunk/bp-groups/bp-groups-functions.php

Timestamp:

06/07/2013 02:06:51 AM (13 years ago)

Author:

boonebgorges

Message:

Improvements to how group total_member_count is refreshed on membership events

• Use an actual member count when refreshing, rather than incrementing
• Centralize all of the updating in the database methods, rather than having the updates spread throughout the groups component

Also adds integration tests for total_member_count as relates to the groups_*
functions.

See #5018

File:

• trunk/bp-groups/bp-groups-functions.php (modified) (5 diffs)

trunk/bp-groups/bp-groups-functions.php

@@ -124 +124 @@
                 $member->save();
 
-                groups_update_groupmeta( $group->id, 'total_member_count', 1 );
                 groups_update_groupmeta( $group->id, 'last_activity', bp_core_current_time() );
 
@@ -299 +298 @@
         if ( !groups_uninvite_user( $user_id, $group_id ) )
                 return false;
-
-        // Modify group member count
-        groups_update_groupmeta( $group_id, 'total_member_count', (int) groups_get_groupmeta( $group_id, 'total_member_count') - 1 );
 
         /**
@@ -362 +358 @@
 
         // Modify group meta
-        groups_update_groupmeta( $group_id, 'total_member_count', (int) groups_get_groupmeta( $group_id, 'total_member_count') + 1 );
         groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
 
@@ -722 +717 @@
 
         // Modify group meta
-        groups_update_groupmeta( $group_id, 'total_member_count', (int) groups_get_groupmeta( $group_id, 'total_member_count') + 1 );
         groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
 
@@ -920 +914 @@
                 groups_delete_invite( $membership->user_id, $membership->group_id );
 
-        // Modify group member count
-        groups_update_groupmeta( $membership->group_id, 'total_member_count', (int) groups_get_groupmeta( $membership->group_id, 'total_member_count') + 1 );
-
         // Record this in activity streams
         $group = groups_get_group( array( 'group_id' => $membership->group_id ) );