Changeset 7172

Timestamp:

06/06/2013 11:24:38 PM (11 years ago)

Author:

boonebgorges

Message:

Set initial group metadata in groups_create_group() rather than action function

Groups created through the user interface have two pieces of metadata set in
groups_action_create_group(): the total_member_count and the last_activity.
(Both items are needed for newly created groups to show up in directories.)
However, the placement of these groups_update_groupmeta() calls - in what is
essentially a controller function - meant that groups created programatically
using groups_create_group() did not have their complete metadata set. Moving
the metadata setting into groups_create_group() means one less step for plugins
and other scripts that create groups programatically.

Fixes #4827

Props ericlewis, rogercoathup

Location:

trunk/bp-groups

Files:

• bp-groups-actions.php (modified) (1 diff)
• bp-groups-functions.php (modified) (1 diff)

trunk/bp-groups/bp-groups-actions.php

@@ -80 +80 @@
                 bp_core_redirect( bp_get_root_domain() . '/' . bp_get_groups_root_slug() . '/create/step/' . bp_get_groups_current_create_step() . '/' );
             }
-
-            groups_update_groupmeta( $bp->groups->new_group_id, 'total_member_count', 1 );
-            groups_update_groupmeta( $bp->groups->new_group_id, 'last_activity', bp_core_current_time() );
         }
 

trunk/bp-groups/bp-groups-functions.php

@@ -123 +123 @@
         $member->date_modified = bp_core_current_time();
         $member->save();
+
+        groups_update_groupmeta( $group->id, 'total_member_count', 1 );
+        groups_update_groupmeta( $group->id, 'last_activity', bp_core_current_time() );
 
         do_action( 'groups_create_group', $group->id, $member, $group );