Changeset 7162

Timestamp:

06/05/2013 03:11:29 AM (11 years ago)

Author:

boonebgorges

Message:

Use jQuery.closest() to find form when submitting activity update

Using closest() instead of traversing with parent() makes the JS much more
flexible, as theme authors are free to change how elements are nested without
breaking the JS.

Fixes #4816

Props hnla

Location:

trunk

Files:

• bp-templates/bp-legacy/js/buddypress.js (modified) (1 diff)
• bp-themes/bp-default/_inc/global.js (modified) (1 diff)

trunk/bp-templates/bp-legacy/js/buddypress.js

@@ -71 +71 @@
     jq("#aw-whats-new-submit").on( 'click', function() {
         var button = jq(this);
-        var form = button.parent().parent().parent().parent();
+        var form = button.closest("form#whats-new-form");
 
         form.children().each( function() {

trunk/bp-themes/bp-default/_inc/global.js

@@ -71 +71 @@
     jq("input#aw-whats-new-submit").click( function() {
         var button = jq(this);
-        var form = button.parent().parent().parent().parent();
+        var form = button.closest("form#whats-new-form");
 
         form.children().each( function() {