Changeset 7150

Timestamp:

06/04/2013 01:45:23 PM (11 years ago)

Author:

boonebgorges

Message:

Populate registration field visibility settings from $_POST, if available

By giving preference to values in the $_POST global when populating the profile
field visibility settings on the registration page, we ensure that users who
modify those values and then submit a failed registration do not have to
reenter the values after the page reloads.

See #4958

Props dcavins

File:

• trunk/bp-xprofile/bp-xprofile-template.php (modified) (2 diffs)

trunk/bp-xprofile/bp-xprofile-template.php

@@ -749 +749 @@
         global $field;
 
-        $retval = !empty( $field->visibility_level ) ? $field->visibility_level : 'public';
+        // On the registration page, values stored in POST should take
+        // precedence over default visibility, so that submitted values
+        // are not lost on failure
+        if ( bp_is_register_page() && ! empty( $_POST['field_' . $field->id . '_visibility'] ) ) {
+            $retval = esc_attr( $_POST['field_' . $field->id . '_visibility'] );
+        } else {
+            $retval = ! empty( $field->visibility_level ) ? $field->visibility_level : 'public';
+        }
 
         return apply_filters( 'bp_get_the_profile_field_visibility_level', $retval );
@@ -766 +773 @@
         global $field;
 
-        $level  = !empty( $field->visibility_level ) ? $field->visibility_level : 'public';
+        // On the registration page, values stored in POST should take
+        // precedence over default visibility, so that submitted values
+        // are not lost on failure
+        if ( bp_is_register_page() && ! empty( $_POST['field_' . $field->id . '_visibility'] ) ) {
+            $level = esc_html( $_POST['field_' . $field->id . '_visibility'] );
+        } else {
+            $level = ! empty( $field->visibility_level ) ? $field->visibility_level : 'public';
+        }
+
         $fields = bp_xprofile_get_visibility_levels();