Changeset 7104 for trunk/bp-core/bp-core-functions.php

Timestamp:

05/24/2013 05:45:22 PM (11 years ago)

Author:

boonebgorges

Message:

Update tests and documentation for bp_core_time_since() to reflect seconds quirk

Fixes #5017

File:

• trunk/bp-core/bp-core-functions.php (modified) (2 diffs)

trunk/bp-core/bp-core-functions.php

@@ -570 +570 @@
  * eg: 4 days
  * eg: 4 weeks and 6 days
+ *
+ * Note that fractions of minutes are not represented in the return string. So
+ * an interval of 3 minutes will be represented by "3 minutes ago", as will an
+ * interval of 3 minutes 59 seconds.
  *
  * @package BuddyPress Core
@@ -671 +675 @@
 
             // Step two: the second chunk
+            // A quirk in the implementation means that this
+            // condition fails in the case of minutes and seconds.
+            // We've left the quirk in place, since fractions of a
+            // minute are not a useful piece of information for our
+            // purposes
             if ( $i + 2 < $j ) {
                 $seconds2 = $chunks[$i + 1];