Changeset 7091 for trunk/bp-groups/bp-groups-template.php

Timestamp:

05/19/2013 02:40:18 AM (11 years ago)

Author:

boonebgorges

Message:

Don't use extract in bp_group_has_members. See #4482

File:

• trunk/bp-groups/bp-groups-template.php (modified) (2 diffs)

trunk/bp-groups/bp-groups-template.php

@@ -1978 +1978 @@
     global $members_template;
 
-    $defaults = array(
+    $r = wp_parse_args( $args, array(
         'group_id' => bp_get_current_group_id(),
         'per_page' => 20,
@@ -1985 +1985 @@
         'exclude_admins_mods' => 1,
         'exclude_banned' => 1
-    );
-
-    $r = wp_parse_args( $args, $defaults );
-    extract( $r, EXTR_SKIP );
-
-    $members_template = new BP_Groups_Group_Members_Template( $group_id, $per_page, $max, (int) $exclude_admins_mods, (int) $exclude_banned, $exclude );
+    ) );
+
+    $members_template = new BP_Groups_Group_Members_Template( $r['group_id'], $r['per_page'], $r['max'], (int) $r['exclude_admins_mods'], (int) $r['exclude_banned'], $r['exclude'] );
     return apply_filters( 'bp_group_has_members', $members_template->has_members(), $members_template );
 }