Changeset 7088

Timestamp:

05/19/2013 12:26:47 AM (13 years ago)

Author:

boonebgorges

Message:

Add sortable column support for the Groups Administration Dashboard panel

The columns have been marked sortable since they were originall introduced, but
the sorting did not work because of limitations in how bp_has_groups() worked.
As of r7087, bp_has_groups() supports 'order' and 'orderby' params, which
allows us to fix this broken feature.

Fixes #4483

File:

• trunk/bp-groups/bp-groups-admin.php (modified) (5 diffs)

trunk/bp-groups/bp-groups-admin.php

@@ -983 +983 @@
                 $per_page = $this->get_items_per_page( str_replace( '-', '_', "{$screen->id}_per_page" ) );
 
-                // Sort order. Note: not supported in bp_has_groups()
-                $order = 'ASC';
+                // Sort order.
+                $order = 'DESC';
                 if ( !empty( $_REQUEST['order'] ) ) {
                         $order = ( 'desc' == strtolower( $_REQUEST['order'] ) ) ? 'DESC' : 'ASC';
@@ -990 +990 @@
 
                 // Order by - default to newest
-                $type = 'newest';
-                if ( !empty( $_REQUEST['orderby'] ) ) {
+                $orderby = 'last_activity';
+                if ( ! empty( $_REQUEST['orderby'] ) ) {
                         switch ( $_REQUEST['orderby'] ) {
                                 case 'name' :
-                                        $type = 'alphabetical';
+                                        $orderby = 'name';
                                         break;
                                 case 'id' :
-                                        $type = 'newest';
+                                        $orderby = 'date_created';
                                         break;
                                 case 'members' :
-                                        $type = 'popular';
+                                        $orderby = 'total_member_count';
+                                        break;
+                                case 'last_active' :
+                                        $orderby = 'last_activity';
                                         break;
                         }
@@ -1041 +1044 @@
                                 'per_page' => $per_page,
                                 'page'     => $page,
-                                'type'     => $type,
+                                'orderby'  => $orderby,
                                 'order'    => $order
                         );
@@ -1193 +1196 @@
          * Get the column names for sortable columns
          *
+         * Note: It's not documented in WP, but the second item in the
+         * nested arrays below is $desc_first. Normally, we would set
+         * last_active to be desc_first (since you're generally interested in
+         * the *most* recently active group, not the *least*). But because
+         * the default sort for the Groups admin screen is DESC by last_active,
+         * we want the first click on the Last Active column header to switch
+         * the sort order - ie, to make it ASC. Thus last_active is set to
+         * $desc_first = false.
+         *
          * @return array
          * @since BuddyPress (1.7)
@@ -1198 +1210 @@
         function get_sortable_columns() {
                 return array(
-                        'gid'         => array( 'gid',         false ),
-                        'comment'     => array( 'name',        false ),
-                        'members'     => array( 'members',     false ),
-                        'last_active' => array( 'last_active', false )
+                        'gid'         => array( 'gid', false ),
+                        'comment'     => array( 'name', false ),
+                        'members'     => array( 'members', false ),
+                        'last_active' => array( 'last_active', false ),
                 );
         }