Changeset 7051

Timestamp:

05/09/2013 02:26:50 PM (12 years ago)

Author:

boonebgorges

Message:

When deleting an activity item, clear its metadata cache

Because of the way that the cache groups are structured, there is no simple
way to figure out which cache keys should be dropped upon deletion. Our
solution is to scan through all the keys in the 'bp' group to determine the
relevant ones. It's not particularly elegant, but this kind of cache-busting
will happen rarely (namely, when an activity item is deleted) so the overhead
is negligible.

Fixes #4804

Location:

trunk/bp-activity

Files:

• bp-activity-cache.php (modified) (1 diff)
• bp-activity-classes.php (modified) (1 diff)

trunk/bp-activity/bp-activity-cache.php

@@ -33 +33 @@
         'cache_key_prefix' => 'bp_activity_meta'
     );
-    
+
     bp_update_meta_cache( $cache_args );
 }
+
+/**
+ * Clear the cache for all metadata of a given activity
+ *
+ * @param int $activity_id
+ */
+function bp_activity_clear_meta_cache_for_activity( $activity_id ) {
+    global $wp_object_cache;
+
+    if ( is_object( $wp_object_cache ) && ! empty( $wp_object_cache->cache['bp'] ) ) {
+        foreach ( $wp_object_cache->cache['bp'] as $ckey => $cvalue ) {
+            if ( 0 === strpos( $ckey, 'bp_activity_meta_' . $activity_id ) ) {
+                wp_cache_delete( $ckey, 'bp' );
+            }
+        }
+    }
+}

trunk/bp-activity/bp-activity-classes.php

@@ -480 +480 @@
         $activity_ids = implode( ',', wp_parse_id_list( $activity_ids ) );
 
+        foreach ( (array) $activity_ids as $activity_id ) {
+            bp_activity_clear_meta_cache_for_activity( $activity_id );
+        }
+
         return $wpdb->query( "DELETE FROM {$bp->activity->table_name_meta} WHERE activity_id IN ({$activity_ids})" );
     }