Changeset 7047 for trunk/tests/testcases/activity/class.BP_Activity_Activity.php

Timestamp:

05/09/2013 02:11:52 PM (13 years ago)

Author:

boonebgorges

Message:

In test suite, factory->activity->create() should return an id, not an object

Two reasons: The value that's almost always needed is an ID, and it's more
consistent with WP's factories.

File:

• trunk/tests/testcases/activity/class.BP_Activity_Activity.php (modified) (6 diffs)

trunk/tests/testcases/activity/class.BP_Activity_Activity.php

@@ -26 +26 @@
 
         $result = BP_Activity_Activity::check_exists_by_content( $content );
-        $this->assertEquals( $activity->id, $result );
+        $this->assertEquals( $activity, $result );
     }
 
@@ -39 +39 @@
         ) );
 
-        BP_Activity_Activity::delete_activity_item_comments( $parent_activity->id );
+        BP_Activity_Activity::delete_activity_item_comments( $parent_activity );
 
         $result = BP_Activity_Activity::get( array( 'in' => wp_list_pluck( $comments, 'id' ), ) );
@@ -53 +53 @@
         ) );
 
-        bp_activity_update_meta( $activity->id, 'Paul', 'is cool' );
-        BP_Activity_Activity::delete_activity_meta_entries( $activity->id );
+        bp_activity_update_meta( $activity, 'Paul', 'is cool' );
+        BP_Activity_Activity::delete_activity_meta_entries( $activity );
 
-        $meta = bp_activity_get_meta( $activity->id, 'Paul' );
+        $meta = bp_activity_get_meta( $activity, 'Paul' );
         $this->assertFalse( $meta );
     }
@@ -68 +68 @@
 
         $activity = BP_Activity_Activity::get( array(
-            'in'          => $activity->id,
+            'in'          => $activity,
             'show_hidden' => true,
         ) );
@@ -77 +77 @@
         $a1 = $this->factory->activity->create();
         $a2 = $this->factory->activity->create();
-        bp_activity_update_meta( $a1->id, 'foo', 'bar' );
+        bp_activity_update_meta( $a1, 'foo', 'bar' );
 
         $activity = BP_Activity_Activity::get( array(
@@ -88 +88 @@
         ) );
         $ids = wp_list_pluck( $activity['activities'], 'id' );
-        $this->assertEquals( $ids, array( $a1->id ) );
+        $this->assertEquals( $ids, array( $a1 ) );
     }
 }