Changeset 7032

Timestamp:

05/09/2013 10:13:39 AM (13 years ago)

Author:

boonebgorges

Message:

Run BP_Core_User results through wp_parse_id_list before test assertions

The return values of some BP_Core_User methods are string-cast integers, which
can cause problems when comparing with true integer arrays using assertEquals().

File:

• trunk/tests/testcases/core/class-bp-core-user.php (modified) (3 diffs)

trunk/tests/testcases/core/class-bp-core-user.php

@@ -44 +44 @@
 
                 $users = BP_Core_User::get_users( 'active', 0, 1, 0, false, false, true, $exclude_array );
-                $user_ids = wp_list_pluck( $users['users'], 'id' );
+                $user_ids = wp_parse_id_list( wp_list_pluck( $users['users'], 'id' ) );
 
                 $this->assertEquals( array( $u2 ), $user_ids );
@@ -57 +57 @@
 
                 $users = BP_Core_User::get_users( 'active', 0, 1, 0, $include_qs );
-                $user_ids = wp_list_pluck( $users['users'], 'id' );
+                $user_ids = wp_parse_id_list( wp_list_pluck( $users['users'], 'id' ) );
 
                 $this->assertEquals( array( $u1, $u3 ), $user_ids );
@@ -94 +94 @@
 
                 $users = BP_Core_User::get_specific_users( $include_array );
-                $user_ids = wp_list_pluck( $users['users'], 'id' );
-
-                // sort...ugh
-                sort( $user_ids );
+                $user_ids = wp_parse_id_list( wp_list_pluck( $users['users'], 'id' ) );
 
                 $this->assertEquals( array( $u1, $u3 ), $user_ids );