Changeset 7020

Timestamp:

05/08/2013 02:45:42 AM (12 years ago)

Author:

johnjamesjacoby

Message:

More array sanitization hardening using wp_parse_id_list() in bp-groups-classes.php. See #4989 (1.7 branch)

File:

• branches/1.7/bp-groups/bp-groups-classes.php (modified) (4 diffs)

branches/1.7/bp-groups/bp-groups-classes.php

@@ -174 +174 @@
         // Fetch the user IDs of all the members of the group
         $user_ids    = BP_Groups_Member::get_group_member_ids( $this->id );
-        $user_id_str = implode( ',', (array) $user_ids );
+        $user_id_str = esc_sql( implode( ',', wp_parse_id_list( $user_ids ) ) );
 
         // Modify group count usermeta for members
@@ -233 +233 @@
             return false;
 
-        $gids = implode( ',', $gids['groups'] );
+        $gids = esc_sql( implode( ',', wp_parse_id_list( $gids['groups'] ) ) );
 
         $paged_groups = $wpdb->get_results( "SELECT id as group_id FROM {$bp->groups->table_name} WHERE ( name LIKE '{$filter}%%' OR description LIKE '{$filter}%%' ) AND id IN ({$gids}) {$pag_sql}" );
@@ -639 +639 @@
 
         // Sanitize group IDs
-        $group_ids = wp_parse_id_list( $group_ids );
-        $group_ids = implode( ',', $group_ids );
+        $group_ids = implode( ',', wp_parse_id_list( $group_ids ) );
 
         // Fetch the logged in users status within each group
@@ -1266 +1265 @@
             $user_ids[] = $user->user_id;
 
-        $user_ids = $wpdb->escape( join( ',', (array) $user_ids ) );
+        $user_ids = implode( ',', wp_parse_id_list( $user_ids ) );
 
         if ( bp_is_active( 'friends' ) ) {