Changeset 6996 for trunk/tests/testcases/core/classes.php

Timestamp:

05/05/2013 06:11:56 PM (13 years ago)

Author:

boonebgorges

Message:

Convert total_friend_count to SIGNED before attempting to sort with it

This fixes issues in BP_User_Query where the 'popular' sort order was sorting
by friend count interpreted as a string (ie, alphabetically) instead of
numerically.

Fixes #4937

Props merty

File:

• trunk/tests/testcases/core/classes.php (modified) (1 diff)

trunk/tests/testcases/core/classes.php

@@ -79 +79 @@
         $this->assertEquals( $friend_ids, array() );
     }
+
+    public function test_bp_user_query_sort_by_popular() {
+        $u1 = $this->create_user();
+        $u2 = $this->create_user();
+        $u3 = $this->create_user();
+        $u4 = $this->create_user();
+
+        bp_update_user_meta( $u1, bp_get_user_meta_key( 'total_friend_count' ), '5' );
+        bp_update_user_meta( $u2, bp_get_user_meta_key( 'total_friend_count' ), '90' );
+        bp_update_user_meta( $u3, bp_get_user_meta_key( 'total_friend_count' ), '101' );
+        bp_update_user_meta( $u4, bp_get_user_meta_key( 'total_friend_count' ), '3002' );
+
+        $q = new BP_User_Query( array(
+            'type' => 'popular',
+        ) );
+
+        $users = is_array( $q->results ) ? array_values( $q->results ) : array();
+        $user_ids = wp_parse_id_list( wp_list_pluck( $users, 'ID' ) );
+
+        $expected = array( $u4, $u3, $u2, $u1 );
+        $this->assertEquals( $expected, $user_ids );
+    }
 }