Changeset 6996 for trunk/bp-core/bp-core-classes.php

Timestamp:

05/05/2013 06:11:56 PM (13 years ago)

Author:

boonebgorges

Message:

Convert total_friend_count to SIGNED before attempting to sort with it

This fixes issues in BP_User_Query where the 'popular' sort order was sorting
by friend count interpreted as a string (ie, alphabetically) instead of
numerically.

Fixes #4937

Props merty

File:

• trunk/bp-core/bp-core-classes.php (modified) (1 diff)

trunk/bp-core/bp-core-classes.php

@@ -235 +235 @@
                                 $sql['select']  = "SELECT DISTINCT u.{$this->uid_name} as id FROM {$wpdb->usermeta} u";
                                 $sql['where'][] = $wpdb->prepare( "u.meta_key = %s", bp_get_user_meta_key( 'total_friend_count' ) );
-                                $sql['orderby'] = "ORDER BY u.meta_value";
+                                $sql['orderby'] = "ORDER BY CONVERT(u.meta_value, SIGNED)";
                                 $sql['order']   = "DESC";