Changeset 6955

Timestamp:

04/26/2013 11:40:21 PM (12 years ago)

Author:

boonebgorges

Message:

Improved UX for "Notify group members of changes" toggle

The "Notify group members...." toggle on the 'edit-details' screen of the group
admin is intended to allow the group administrator to send an email to the
group members when the group's name or description has changed. However, the
legacy UX - a radio button (suggesting a persistent setting), and the text
(which suggests persistent notifications) - have historically been misleading.
By changing the radio button to a checkbox, and making a slight modification to
the wording of the text, the purpose of the checkbox should be much clearer.

See #4344

Location:

trunk

Files:

• bp-groups/bp-groups-screens.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/groups/single/admin.php (modified) (1 diff)
• bp-themes/bp-default/groups/single/admin.php (modified) (1 diff)

trunk/bp-groups/bp-groups-screens.php

@@ -524 +524 @@
                 return false;
 
-            if ( !groups_edit_base_group_details( $_POST['group-id'], $_POST['group-name'], $_POST['group-desc'], (int) $_POST['group-notify-members'] ) ) {
+            $group_notify_members = isset( $_POST['group-notify-members'] ) ? (int) $_POST['group-notify-members'] : 0;
+
+            if ( !groups_edit_base_group_details( $_POST['group-id'], $_POST['group-name'], $_POST['group-desc'], $group_notify_members ) ) {
                 bp_core_add_message( __( 'There was an error updating group details, please try again.', 'buddypress' ), 'error' );
             } else {

trunk/bp-templates/bp-legacy/buddypress/groups/single/admin.php

@@ -23 +23 @@
 
     <p>
-        <label for="group-notifiy-members"><?php _e( 'Notify group members of changes via email', 'buddypress' ); ?></label>
-        <input type="radio" name="group-notify-members" value="1" /> <?php _e( 'Yes', 'buddypress' ); ?>&nbsp;
-        <input type="radio" name="group-notify-members" value="0" checked="checked" /> <?php _e( 'No', 'buddypress' ); ?>&nbsp;
+        <label for="group-notifiy-members">
+            <input type="checkbox" name="group-notify-members" value="1" /> <?php _e( 'Notify group members of these changes via email', 'buddypress' ); ?>
+        </label>
     </p>
 

trunk/bp-themes/bp-default/groups/single/admin.php

@@ -23 +23 @@
 
     <p>
-        <label for="group-notifiy-members"><?php _e( 'Notify group members of changes via email', 'buddypress' ); ?></label>
-        <input type="radio" name="group-notify-members" value="1" /> <?php _e( 'Yes', 'buddypress' ); ?>&nbsp;
-        <input type="radio" name="group-notify-members" value="0" checked="checked" /> <?php _e( 'No', 'buddypress' ); ?>&nbsp;
+        <label for="group-notifiy-members">
+            <input type="checkbox" name="group-notify-members" value="1" /> <?php _e( 'Notify group members of these changes via email', 'buddypress' ); ?>
+        </label>
     </p>