Skip to:
Content

BuddyPress.org

Changeset 6955


Ignore:
Timestamp:
04/26/2013 11:40:21 PM (8 years ago)
Author:
boonebgorges
Message:

Improved UX for "Notify group members of changes" toggle

The "Notify group members...." toggle on the 'edit-details' screen of the group
admin is intended to allow the group administrator to send an email to the
group members when the group's name or description has changed. However, the
legacy UX - a radio button (suggesting a persistent setting), and the text
(which suggests persistent notifications) - have historically been misleading.
By changing the radio button to a checkbox, and making a slight modification to
the wording of the text, the purpose of the checkbox should be much clearer.

See #4344

Location:
trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-groups/bp-groups-screens.php

    r6876 r6955  
    524524                return false;
    525525
    526             if ( !groups_edit_base_group_details( $_POST['group-id'], $_POST['group-name'], $_POST['group-desc'], (int) $_POST['group-notify-members'] ) ) {
     526            $group_notify_members = isset( $_POST['group-notify-members'] ) ? (int) $_POST['group-notify-members'] : 0;
     527
     528            if ( !groups_edit_base_group_details( $_POST['group-id'], $_POST['group-name'], $_POST['group-desc'], $group_notify_members ) ) {
    527529                bp_core_add_message( __( 'There was an error updating group details, please try again.', 'buddypress' ), 'error' );
    528530            } else {
  • trunk/bp-templates/bp-legacy/buddypress/groups/single/admin.php

    r6284 r6955  
    2323
    2424    <p>
    25         <label for="group-notifiy-members"><?php _e( 'Notify group members of changes via email', 'buddypress' ); ?></label>
    26         <input type="radio" name="group-notify-members" value="1" /> <?php _e( 'Yes', 'buddypress' ); ?>&nbsp;
    27         <input type="radio" name="group-notify-members" value="0" checked="checked" /> <?php _e( 'No', 'buddypress' ); ?>&nbsp;
     25        <label for="group-notifiy-members">
     26            <input type="checkbox" name="group-notify-members" value="1" /> <?php _e( 'Notify group members of these changes via email', 'buddypress' ); ?>
     27        </label>
    2828    </p>
    2929
  • trunk/bp-themes/bp-default/groups/single/admin.php

    r5879 r6955  
    2323
    2424    <p>
    25         <label for="group-notifiy-members"><?php _e( 'Notify group members of changes via email', 'buddypress' ); ?></label>
    26         <input type="radio" name="group-notify-members" value="1" /> <?php _e( 'Yes', 'buddypress' ); ?>&nbsp;
    27         <input type="radio" name="group-notify-members" value="0" checked="checked" /> <?php _e( 'No', 'buddypress' ); ?>&nbsp;
     25        <label for="group-notifiy-members">
     26            <input type="checkbox" name="group-notify-members" value="1" /> <?php _e( 'Notify group members of these changes via email', 'buddypress' ); ?>
     27        </label>
    2828    </p>
    2929
Note: See TracChangeset for help on using the changeset viewer.