Changeset 6943 for trunk/bp-messages/bp-messages-template.php

Timestamp:

04/26/2013 01:59:46 AM (12 years ago)

Author:

boonebgorges

Message:

Introduces bp_get_send_message_button_args filter

Most buttons have a filter on the args that are passed to bp_has_button().
The bp-messages Send Message button filter 'bp_get_send_message_button', in
contrast, is on the HTML return value of bp_has_button(). This was probably
a mistake in the original implementation. However, simply moving the existing
filter would break compatibility with existing implementations that use it. So
we've added a new filter, which works the same as other button filters, but has
a slightly different naming convention.

Fixes #4536

Props megainfo, rogercoathup

File:

• trunk/bp-messages/bp-messages-template.php (modified) (2 diffs)

trunk/bp-messages/bp-messages-template.php

@@ -640 +640 @@
 }
     function bp_get_send_message_button() {
+        // Note: 'bp_get_send_message_button' is a legacy filter. Use
+        // 'bp_get_send_message_button_args' instead. See #4536
         return apply_filters( 'bp_get_send_message_button',
-            bp_get_button( array(
+            bp_get_button( apply_filters( 'bp_get_send_message_button_args', array(
                 'id'                => 'private_message',
                 'component'         => 'messages',
@@ -651 +653 @@
                 'link_text'         => __( 'Private Message', 'buddypress' ),
                 'link_class'        => 'send-message',
-            ) )
+            ) ) )
         );
     }