Changeset 6919

Timestamp:

04/18/2013 12:43:13 AM (11 years ago)

Author:

boonebgorges

Message:

Use event delegation for AJAX buttons in Groups and Members directories

In r6635, BP's use of the deprecated jQuery.live() was switched to jQuery.on().
However, the change was not made in a way that preserved the behavior of live()
with respect to items added to the DOM dynamically, as per an AJAX callback.
We replicate that behavior by using jQuery.on() delegation on a persistent
parent element. That way, group directory buttons (Join/Leave) and member
directory buttons (Add Friend/Remove Friend) continue to work even when the
view is refreshed via AJAX, as in pagination or reordering.

Fixes #4931

File:

• branches/1.7/bp-themes/bp-default/_inc/global.js (modified) (2 diffs)

branches/1.7/bp-themes/bp-default/_inc/global.js

@@ -888 +888 @@
 
     /* Add / Remove friendship buttons */
-    jq(".friendship-button a").on('click', function() {
+    jq('#members-dir-list').on('click', '.friendship-button a', function() {
         jq(this).parent().addClass('loading');
         var fid = jq(this).attr('id');
@@ -938 +938 @@
     /** Group Join / Leave Buttons **************************************/
 
-    jq(".group-button a").on('click', function() {
+    jq('#groups-dir-list').on('click', '.group-button a', function() {
         var gid = jq(this).parent().attr('id');
         gid = gid.split('-');