Changeset 6818

Timestamp:

02/23/2013 06:53:41 PM (12 years ago)

Author:

boonebgorges

Message:

When favoriting an activity item, only attempt to add My Favorites tab if Favorites tab is not already present

This prevents adding My Favorites in the context of a member/group activity
stream, while allowing the tab to be added on the global Activity directory
as intended.

Fixes #4849

File:

• trunk/bp-templates/bp-legacy/js/buddypress.js (modified) (1 diff)

trunk/bp-templates/bp-legacy/js/buddypress.js

@@ -209 +209 @@
 
                 if ( 'fav' == type ) {
-                    if ( !jq('.item-list-tabs #activity-favorites').length )
-                        jq('.item-list-tabs ul #activity-mentions').before( '<li id="activity-favorites"><a href="#">' + BP_DTheme.my_favs + ' <span>0</span></a></li>');
+                    if ( !jq('.item-list-tabs #activity-mentions-personal-li').length ) {
+                        if ( !jq('.item-list-tabs #activity-favorites').length )
+                            jq('.item-list-tabs ul #activity-mentions').before( '<li id="activity-favorites"><a href="#">' + BP_DTheme.my_favs + ' <span>0</span></a></li>');
+
+                        jq('.item-list-tabs ul #activity-favorites span').html( Number( jq('.item-list-tabs ul #activity-favorites span').html() ) + 1 );
+                    }
 
                     target.removeClass('fav');
                     target.addClass('unfav');
 
-                    jq('.item-list-tabs ul #activity-favorites span').html( Number( jq('.item-list-tabs ul #activity-favorites span').html() ) + 1 );
                 } else {
                     target.removeClass('unfav');