Changeset 6809

Timestamp:

02/21/2013 12:53:31 PM (12 years ago)

Author:

boonebgorges

Message:

Don't use event delegation in bp_core_confirmation_js()

Event bubbling prevents the JS confirm dialog from working properly.

This commit reverts changes introduced in #6597. See #4458

Fixes #4843. Props sbrajesh

File:

• trunk/bp-core/bp-core-cssjs.php (modified) (1 diff)

trunk/bp-core/bp-core-cssjs.php

@@ -17 +17 @@
     <script type="text/javascript">
         jQuery( document ).ready( function() {
-            jQuery( 'body' ).click( function(e) {
-                if ( 'a' == e.target.nodeName.toLowerCase() && jQuery(e.target).hasClass( 'confirm' ) ) {
-                    if ( confirm( '<?php _e( 'Are you sure?', 'buddypress' ) ?>' ) )
-                        return true; else return false;
-                } else {
-                    return true;
-                }
+            jQuery( 'a.confirm').click( function() {
+                if ( confirm( '<?php _e( 'Are you sure?', 'buddypress' ) ?>' ) )
+                    return true; else return false;
             });
         });