Skip to:
Content

Changeset 6725


Ignore:
Timestamp:
01/18/13 07:43:09 (15 months ago)
Author:
r-a-y
Message:

Change 'title' attribute for topic links in group forum loop template.

In the topic title link, bp_the_topic_title() is used twice: once
in the 'title' attribute and again for the anchor text.

For plugin devs wanting to manipulate the HTML markup for the topic
title, this would cause unintended output in the 'title' attribute.

Therefore, this commit removes bp_the_topic_title() from the 'title'
attribute for topic links.

Fixes #4770. Props chouf1.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/bp-templates/bp-legacy/buddypress/forums/forums-loop.php

    r6284 r6725  
    5252            <tr class="<?php bp_the_topic_css_class(); ?>"> 
    5353                <td class="td-title"> 
    54                     <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php bp_the_topic_title(); ?> - <?php _e( 'Permalink', 'buddypress' ); ?>"> 
     54                    <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php _e( 'Permanent link to this post', 'buddypress' ); ?>"> 
    5555 
    5656                        <?php bp_the_topic_title(); ?> 
  • trunk/bp-themes/bp-default/forums/forums-loop.php

    r5095 r6725  
    5252            <tr class="<?php bp_the_topic_css_class(); ?>"> 
    5353                <td class="td-title"> 
    54                     <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php bp_the_topic_title(); ?> - <?php _e( 'Permalink', 'buddypress' ); ?>"> 
     54                    <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php _e( 'Permanent link to this post', 'buddypress' ); ?>"> 
    5555 
    5656                        <?php bp_the_topic_title(); ?> 
Note: See TracChangeset for help on using the changeset viewer.