Changeset 6557 for branches/1.6/bp-members/bp-members-functions.php

Timestamp:

12/04/2012 12:03:40 PM (13 years ago)

Author:

djpaul

Message:

Fix alot of WPDB->Prepare() warnings in the 1.6 branch. See #4654

File:

• branches/1.6/bp-members/bp-members-functions.php (modified) (2 diffs)

branches/1.6/bp-members/bp-members-functions.php

@@ -479 +479 @@
     if ( !$count = wp_cache_get( 'bp_total_member_count', 'bp' ) ) {
         $status_sql = bp_core_get_status_sql();
-        $count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM $wpdb->users WHERE {$status_sql}" ) );
+        $count = $wpdb->get_var( "SELECT COUNT(ID) FROM $wpdb->users WHERE {$status_sql}" );
         wp_cache_set( 'bp_total_member_count', $count, 'bp' );
     }
@@ -497 +497 @@
         // Avoid a costly join by splitting the lookup
         if ( is_multisite() ) {
-            $sql = $wpdb->prepare( "SELECT ID FROM $wpdb->users WHERE (user_status != 0 OR deleted != 0 OR user_status != 0)" );
+            $sql = "SELECT ID FROM $wpdb->users WHERE (user_status != 0 OR deleted != 0 OR user_status != 0)";
         } else {
-            $sql = $wpdb->prepare( "SELECT ID FROM $wpdb->users WHERE user_status != 0" );
+            $sql = "SELECT ID FROM $wpdb->users WHERE user_status != 0";
         }
 
         $exclude_users = $wpdb->get_col( $sql );
-        $exclude_users_sql = !empty( $exclude_users ) ? $wpdb->prepare( "AND user_id NOT IN (" . implode( ',', wp_parse_id_list( $exclude_users ) ) . ")" ) : '';
+        $exclude_users_sql = !empty( $exclude_users ) ? "AND user_id NOT IN (" . implode( ',', wp_parse_id_list( $exclude_users ) ) . ")" : '';
 
         $count = (int) $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(user_id) FROM $wpdb->usermeta WHERE meta_key = %s {$exclude_users_sql}", bp_get_user_meta_key( 'last_activity' ) ) );