Changeset 6340

Timestamp:

09/17/2012 05:36:46 AM (12 years ago)

Author:

r-a-y

Message:

Fix messages_new_message() so numeric usernames get parsed properly.

Previously to this commit, numeric recipients were being checked
against the user ID column with bp_core_get_core_userdata() only.

This was considered okay since you cannot create a username with only
numbers on the BP frontend registration page. However, you can create
numeric usernames in the WP backend or if the site already uses
numeric usernames via LDAP or some other login system.

So, this commit also checks against user_login / user_nicename with
bp_core_get_userid() / bp_core_get_userid_from_nicename() as well to
be considerate to those use cases.

Fixes #4305.

File:

• trunk/bp-messages/bp-messages-functions.php (modified) (1 diff)

trunk/bp-messages/bp-messages-functions.php

@@ -69 +69 @@
         foreach( (array) $recipients as $recipient ) {
             $recipient = trim( $recipient );
+
             if ( empty( $recipient ) )
                 continue;
 
+            $recipient_id = false;
+
+            // input was numeric
             if ( is_numeric( $recipient ) ) {
+                // do a check against the user ID column first
                 if ( bp_core_get_core_userdata( (int) $recipient ) )
                     $recipient_id = (int) $recipient;
+
+                // if that fails, check against the user_login / user_nicename column
+                else {
+                    if ( bp_is_username_compatibility_mode() )
+                        $recipient_id = bp_core_get_userid( (int) $recipient );
+                    else
+                        $recipient_id = bp_core_get_userid_from_nicename( (int) $recipient );
+                }
 
             } else {