Changeset 6310 for trunk/bp-activity/bp-activity-akismet.php

Timestamp:

09/06/2012 04:24:22 AM (12 years ago)

Author:

johnjamesjacoby

Message:

Admin Audit:

• Introduce bp_is_network_activated() to tell if BuddyPress is active at a network level.
• Use bp_is_network_activated() in places where multiblog or single-site activation might mistakingly link to the incorrect site/network admin.
• Add phpdoc to bp_is_multiblog_mode() to further explain why it exists, and why you should not use it.
• Audit usage of network_admin_url() and admin_url(), and replace with bp_get_admin_url() where appropriate.
• Escape some admin URL usages; maybe more to do here.

File:

• trunk/bp-activity/bp-activity-akismet.php (modified) (2 diffs)

trunk/bp-activity/bp-activity-akismet.php

@@ -98 +98 @@
                 $b[ $k ] = $item;
                 if ( $k == 'edit' )
-                    $b['history'] = '<a href="' . network_admin_url( 'admin.php?page=bp-activity&amp;action=edit&aid=' . $activity['id'] ) . '#bp_activity_history"> '. __( 'History', 'buddypress' ) . '</a>';
+                    $b['history'] = '<a href="' . esc_url( bp_get_admin_url( 'admin.php?page=bp-activity&amp;action=edit&aid=' . $activity['id'] ) ) . '#bp_activity_history"> '. __( 'History', 'buddypress' ) . '</a>';
             }
 
@@ -105 +105 @@
 
         if ( $desc )
-            echo '<span class="akismet-status"><a href="' . network_admin_url( 'admin.php?page=bp-activity&amp;action=edit&aid=' . $activity['id'] ) . '#bp_activity_history">' . htmlspecialchars( $desc ) . '</a></span>';
+            echo '<span class="akismet-status"><a href="' . esc_url( bp_get_admin_url( 'admin.php?page=bp-activity&amp;action=edit&aid=' . $activity['id'] ) ) . '#bp_activity_history">' . htmlspecialchars( $desc ) . '</a></span>';
 
         return apply_filters( 'bp_akismet_comment_row_action', $actions );