Changeset 6253

Timestamp:

08/13/2012 11:07:49 PM (12 years ago)

Author:

boonebgorges

Message:

When running NOBLOGREDIRECT, rehook maybe_redirect_404() to priority 100.

WP's maybe_redirect_404() must run after BuddyPress's template loader function
bp_core_load_template(), or else it'll register incorrectly as a 404 and
redirect to the value of NOBLOGREDIRECT. See inline documentation for more
details.

Fixes #4415

File:

• trunk/bp-core/bp-core-catchuri.php (modified) (1 diff)

trunk/bp-core/bp-core-catchuri.php

@@ -682 +682 @@
 
 /**
+ * Rehook maybe_redirect_404() to run later than the default
+ *
+ * WordPress's maybe_redirect_404() allows admins on a multisite installation
+ * to define 'NOBLOGREDIRECT', a URL to which 404 requests will be redirected.
+ * maybe_redirect_404() is hooked to template_redirect at priority 10, which
+ * creates a race condition with bp_template_redirect(), our piggyback hook.
+ * Due to a legacy bug in BuddyPress, internal BP content (such as members and
+ * groups) is marked 404 in $wp_query until bp_core_load_template(), when BP
+ * manually overrides the automatic 404. However, the race condition with
+ * maybe_redirect_404() means that this manual un-404-ing doesn't happen in
+ * time, with the results that maybe_redirect_404() thinks that the page is
+ * a legitimate 404, and redirects incorrectly to NOBLOGREDIRECT.
+ *
+ * By switching maybe_redirect_404() to catch at a higher priority, we avoid
+ * the race condition. If bp_core_load_template() runs, it dies before reaching
+ * maybe_redirect_404(). If bp_core_load_template() does not run, it means that
+ * the 404 is legitimate, and maybe_redirect_404() can proceed as expected.
+ *
+ * This function will be removed in a later version of BuddyPress. Plugins
+ * (and plugin authors!) should ignore it.
+ *
+ * @since 1.6.1
+ *
+ * @link http://buddypress.trac.wordpress.org/ticket/4329
+ * @link http://buddypress.trac.wordpress.org/ticket/4415
+ */
+function _bp_rehook_maybe_redirect_404() {
+    if ( defined( 'NOBLOGREDIRECT' ) ) {
+        remove_action( 'template_redirect', 'maybe_redirect_404' );
+        add_action( 'template_redirect', 'maybe_redirect_404', 100 );
+    }
+}
+add_action( 'template_redirect', '_bp_rehook_maybe_redirect_404', 1 );
+
+/**
  * Remove WordPress's rel=canonical HTML tag if we are trying to load BuddyPress
  * specific content.