Changeset 6172

Timestamp:

07/09/2012 08:42:55 PM (14 years ago)

Author:

boonebgorges

Message:

Adds a generic 'activity-item' class to bp_activity_css_class()

Having no class that was shared by all and only activity items made it
difficult to write JavaScript (as for, example, the Favorite and Remove
Favorite buttons) that would select in an elegant way that was not dependent
on HTML element names.

Fixes #4332

Props imath

Location:

trunk

Files:

• bp-activity/bp-activity-template.php (modified) (1 diff)
• bp-themes/bp-default/_inc/global.js (modified) (1 diff)

trunk/bp-activity/bp-activity-template.php

@@ -2011 +2011 @@
                 ) );
 
-                $class = '';
+                $class = ' activity-item';
+
                 if ( in_array( $activities_template->activity->type, (array) $mini_activity_actions ) || empty( $activities_template->activity->content ) )
-                        $class = ' mini';
+                        $class .= ' mini';
 
                 if ( bp_activity_get_comment_count() && bp_activity_can_comment() )

trunk/bp-themes/bp-default/_inc/global.js

@@ -189 +189 @@
                 if ( target.hasClass('fav') || target.hasClass('unfav') ) {
                         var type = target.hasClass('fav') ? 'fav' : 'unfav';
-                        var parent = target.closest('.activity_update');
+                        var parent = target.closest('.activity-item');
                         var parent_id = parent.attr('id').substr( 9, parent.attr('id').length );