Changeset 6156 for trunk/bp-core/bp-core-admin.php

Timestamp:

06/30/2012 01:26:18 PM (13 years ago)

Author:

boonebgorges

Message:

Settings improvements

• Corrects the logic of bp-disable-blogforum-comments, so that checking the 'Enable' setting actually enables rather than disables
• Moves settings saving to its own function bp_core_admin_settings_save(), which can be run earlier in the load process and then redirect, ensuring that the correct settings are rendered in the first pageload after save

Fixes #4301

File:

• trunk/bp-core/bp-core-admin.php (modified) (1 diff)

trunk/bp-core/bp-core-admin.php

@@ -340 +340 @@
             // Activity commenting on blog and forum posts
             add_settings_field( 'bp-disable-blogforum-comments', __( 'Blog & Forum Comments', 'buddypress' ), 'bp_admin_setting_callback_blogforum_comments', 'buddypress', 'bp_activity' );
-            register_setting( 'buddypress', 'bp-disable-blogforum-comments', 'intval' );
+            register_setting( 'buddypress', 'bp-disable-blogforum-comments', 'bp_admin_sanitize_callback_blogforum_comments' );
 
             // Allow activity akismet