Changeset 6117

Timestamp:

06/19/2012 12:18:19 PM (14 years ago)

Author:

boonebgorges

Message:

In xprofile_admin_manage_field(), make sure $field_id is set before setting meta

When creating a new profile field, it's necessary to ensure that $field_id is
set, or calls to bp_xprofile_update_meta() and related wrapper functions will
fail. That means that, eg, field visibility settings are not properly stored
on the initial field creation. This changeset fixes the problem by ensuring
that $field_id has been populated before carrying on with the setup routine.

See #4275

Props imath

File:

• trunk/bp-xprofile/bp-xprofile-admin.php (modified) (1 diff)

trunk/bp-xprofile/bp-xprofile-admin.php

@@ -258 +258 @@
             }
 
-            if ( !$field->save() ) {
+            // For new profile fields, set the $field_id. For existing profile fields,
+            // this will overwrite $field_id with the same value.
+            $field_id = $field->save();
+
+            if ( !$field_id ) {
                 $message = __( 'There was an error saving the field. Please try again', 'buddypress' );
                 $type = 'error';