Changeset 6051 for trunk/bp-themes/bp-default/registration/register.php

Timestamp:

05/31/2012 08:42:53 PM (13 years ago)

Author:

boonebgorges

Message:

Markup enhancements for profile visibility

• Removes an orphaned 'label' element
• Replaces some 'label' elements with 'fieldset' and 'legend' for greater accuracy
• Changes some div elements into paragraphs, so that text does not appear outside the context of semantic elements
• Modifications to the visibility options toggle JavaScript, for better differentiation and smoothness

Fixes #4224
Props hnla

File:

• trunk/bp-themes/bp-default/registration/register.php (modified) (1 diff)

trunk/bp-themes/bp-default/registration/register.php

@@ -156 +156 @@
                                 
                                 <?php if ( bp_current_user_can( 'bp_xprofile_change_field_visibility' ) ) : ?>
-                                    <div class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
+                                    <p class="field-visibility-settings-toggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
                                         <?php printf( __( 'This field can be seen by: <span class="current-visibility-level">%s</span>', 'buddypress' ), bp_get_the_profile_field_visibility_level_label() ) ?> <a href="#" class="visibility-toggle-link">Change</a>
-                                    </div>
+                                    </p>
                                     
                                     <div class="field-visibility-settings" id="field-visibility-settings-<?php bp_the_profile_field_id() ?>">
-                                        <label for="field-visibility"><?php _e( 'Who can see this field?', 'buddypress' ) ?></label>
+                                        <fieldset>
+                                            <legend><?php _e( 'Who can see this field?', 'buddypress' ) ?></legend>
                                         
-                                        <?php bp_profile_visibility_radio_buttons() ?>
+                                            <?php bp_profile_visibility_radio_buttons() ?>
                                         
+                                        </fieldset>
                                         <a class="field-visibility-settings-close" href="#"><?php _e( 'Close', 'buddypress' ) ?></a>
+                                        
                                     </div>
                                 <?php else : ?>
-                                    <div class="field-visibility-settings-notoggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
+                                    <p class="field-visibility-settings-notoggle" id="field-visibility-settings-toggle-<?php bp_the_profile_field_id() ?>">
                                         <?php printf( __( 'This field can be seen by: <span class="current-visibility-level">%s</span>', 'buddypress' ), bp_get_the_profile_field_visibility_level_label() ) ?>
-                                    </div>          
+                                    </p>            
                                 <?php endif ?>